Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] remove support for 'info' in Dataset #4866

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

Contributes to #4543.

This PR proposes removing the keyword argument info from functions used for creating and manipulating Datasets. After this PR, users of the R package will have to provide init_score, label, weight, and group via the keyword arguments added in #4573.

Notes for Reviewers

v3.3.0 and v3.3.1 contain a deprecation warning about this change.

This PR is focused only on the public parts of the package's API. A future PR might propose replacing Dataset$private$info with e.g. Dataset$private$init_score, Dataset$private$label.

@StrikerRUS StrikerRUS merged commit 3ede5fa into master Dec 7, 2021
@StrikerRUS StrikerRUS deleted the dataset-no-info branch December 7, 2021 20:08
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants