-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Start supporting Python 3.10 #4893
Conversation
advanced_example.py fails during executing on
This fail occurs due to compatibility problems with old Ubuntu 14.04 (old glibc actually) and OpenMP.
This error shouldn't occur with |
It's getting harder and harder to support a such old version of Ubuntu (14.04) ... |
Thanks for the additional research and issues you linked to! conda-forge/conda-forge.github.io#1551 is especially troubling 😞 According to https://ubuntu.com/about/release-cycle#ubuntu-kernel-release-cycle, Ubuntu 14.04 was first released in 2014, starting in 2019 it went into "only receiving security patches" mode, and it will be in that mode until 2024. Given all that, I'd like to try to keep supporting it, but also acknowledge that we have a limited amount of time and energy to spend on maintaining this project. Since the issues you linked are all related to OpenMP, what do you think about switching Ubuntu 14.04 builds to using LightGBM/python-package/setup.py Line 25 in 2d1caf1
Maybe that could be a manageable compromise between "spend time trying to get this working on Ubuntu 14.04" and "stop testing on Ubuntu 14.04 entirely". |
A lot of CI jobs with Ubuntu 14.04 are used to produce public artifacts Lines 72 to 73 in 2d1caf1
I don't think it's a good idea to build artifacts with --nomp flag...
I'm thinking about to simply re-arange Python versions there because it seems that only 3.10 one has compatibility problems. |
@@ -35,17 +35,18 @@ jobs: | |||
matrix: | |||
regular: | |||
TASK: regular | |||
PYTHON_VERSION: '3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use different Python versions for the same TASK
in Linux
and Linux_latest
jobs. The same is true for macOS configurations on Azure Pipelines and GitHub Actions.
I believe this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent! thanks for doing this! And for the explanation about why it is necessary to add quotes in the config 😂
"3.7" {$env:MINICONDA = "C:\Miniconda37-x64"} | ||
default {$env:MINICONDA = "C:\Miniconda37-x64"} | ||
} | ||
$env:MINICONDA = "C:\Miniconda3-x64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! haha I never noticed that these two values were the same.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Python 3.10 was released 2021-10-04.
https://devguide.python.org/#branchstatus
Why enclose Python version in quotes: #3880 (comment).
WIP Due to
dask=2021.9.1
isn't compatible with Python 3.10;LightGBM/.ci/test.sh
Line 117 in 8e729af
numpy
and other dependencies from sources takes more than 30 minutes.