-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] clarify that categorical features will be converted to integers internally #4959
Conversation
… should be ints in the input data
I think there are more places where this clarification should be made for the consistency in docs. See #1567 for example. |
Close and reopen to retrigger ci tests. |
Haha no worries |
@jmoralez Thank you for doing this. Could you please rerun this script (https://github.com/microsoft/LightGBM/blob/master/helpers/parameter_generator.py) |
Thanks @shiyu1994. I didin't know I had to change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clarification!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Emphasizes that categorical features will be converted to
int
internally, to avoid the confusion that they should be provided as integers in the input data, as was asked in #4932. Also adds information on what will happen if negative values are found.Here's how that section looks like:
Closes #4932.