-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [docs] clarify shape of predictions #5384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael Mayer <mayermichael79@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just have to shorten the lines to fix the linting issues.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
In #5223, @mayer79 pointed out that the R package's documentation doesn't currently describe how to interpret
leaf
orcontrib
predictions for multiclass objectives.This PR proposes adding such documentation to help users and developers creating extensions like
{shapviz}
and{SHAPforxgboost}
.See #5223 (comment) for specific evidence supporting what's being proposed here.
@mayer79 if you have time, we'd be grateful for a review on this from you as well. No rush on that.... the project's CI is currently broken anyway 😬 (#5362 (comment))