Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] [docs] clarify shape of predictions #5384

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Conversation

jameslamb
Copy link
Collaborator

In #5223, @mayer79 pointed out that the R package's documentation doesn't currently describe how to interpret leaf or contrib predictions for multiclass objectives.

This PR proposes adding such documentation to help users and developers creating extensions like {shapviz} and {SHAPforxgboost}.

See #5223 (comment) for specific evidence supporting what's being proposed here.

@mayer79 if you have time, we'd be grateful for a review on this from you as well. No rush on that.... the project's CI is currently broken anyway 😬 (#5362 (comment))

@jameslamb jameslamb added the doc label Jul 20, 2022
@jameslamb jameslamb requested a review from StrikerRUS July 20, 2022 14:58
@jameslamb jameslamb requested a review from jmoralez as a code owner July 20, 2022 14:58
Copy link
Contributor

@mayer79 mayer79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

R-package/R/lgb.Booster.R Outdated Show resolved Hide resolved
R-package/R/lgb.Booster.R Outdated Show resolved Hide resolved
jameslamb and others added 2 commits July 20, 2022 10:42
Co-authored-by: Michael Mayer <mayermichael79@gmail.com>
Copy link
Collaborator

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have to shorten the lines to fix the linting issues.

R-package/R/lgb.Booster.R Outdated Show resolved Hide resolved
R-package/R/lgb.Booster.R Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants