-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] temporarily pin scipy version and fix Python linting error #5398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I can work on trying to remove these pins in the future.
I checked, and I'm guessing the new linting error (build link) is caused by the release of pycodestyle
2.9.0 about 3 days ago: https://pypi.org/project/pycodestyle/#history. Maybe it just made it to conda-forge
.
Linting Python code
./python-package/lightgbm/basic.py:1510:31: E275 missing whitespace after keyword
I don't need to re-approve when you fix that...I'm in favor of altering the code in basic.py
to comply with what pycodestyle
wants, but I trust whatever decision you make about that.
At first, I thought that that linting CI job fail is a false positive, but after a precise check I see we really have a linting error in our codebase. No whitespace after LightGBM/python-package/lightgbm/basic.py Line 1510 in cdc83a5
|
Wow! I stared at that line for a long time and also wasn't sure what it was complaining about. Great work. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Unblock CI in this repo.
Temp workaround for #5390.