[python-package] ignore training set on early stopping callback (fixes #5354) #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoralez
changed the title
jmoralez
requested review from
StrikerRUS,
shiyu1994 and
jameslamb
as code owners
jmoralez
commented
Aug 11, 2022
|
|
||
| eval_records = {} | ||
| callbacks = [ | ||
| lgb.record_evaluation(eval_records), | ||
| lgb.log_evaluation(2), | ||
| lgb.early_stopping(4) | ||
| lgb.early_stopping(10) |
There was a problem hiding this comment.
I changed this because otherwise it would stop at the 4th iteration, this was due to the training set being ignored for early stopping but now early stopping is disabled if you only provide the training set as valid, so I had to provide a dummy validation set.
| @@ -1124,11 +1124,6 @@ def fit_and_check(eval_set_names, metric_names, assumed_iteration, first_metric_ | |||
| iter_min = min([iter_min_l1, iter_min_l2]) | |||
| iter_min_valid1 = min([iter_valid1_l1, iter_valid1_l2]) | |||
|
|
|||
| # training data as eval_set | |||
There was a problem hiding this comment.
I think we shouldn't test this anymore but I'm open to modify it by adding an extra validation set so that we can check the training results
jameslamb
requested changes
Aug 23, 2022
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
approved these changes
Aug 25, 2022
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5354