Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] prefix is_numpy_column_array with _ #5531

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

Madnex
Copy link
Contributor

@Madnex Madnex commented Oct 10, 2022

Contributes to #5313

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestion from #5532 (comment) about modifying the git metadata.

@Madnex Madnex force-pushed the is_numpy_column_array branch from b98766e to da9d07c Compare October 11, 2022 06:00
@Madnex
Copy link
Contributor Author

Madnex commented Oct 11, 2022

Thanks for the tipp! I added my email in the git config :)

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. Thanks for your help with this project!

@jameslamb jameslamb merged commit 8bd5e89 into microsoft:master Oct 11, 2022
@Madnex Madnex deleted the is_numpy_column_array branch October 17, 2022 06:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants