Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] remove unused imports #5559

Merged
merged 2 commits into from
Nov 4, 2022
Merged

[python-package] remove unused imports #5559

merged 2 commits into from
Nov 4, 2022

Conversation

jameslamb
Copy link
Collaborator

Removes some unused imports.

Found with flake8:

python-package/lightgbm/dask.py:20:1: F401 '.basic._safe_call' imported but unused
python-package/lightgbm/dask.py:24:1: F401 '.sklearn._LGBM_ScikitCustomEvalFunction' imported but unused
python-package/lightgbm/sklearn.py:6:1: F401 'typing.Iterable' imported but unused

This was referenced Oct 30, 2022
Closed
Closed
jmoralez
jmoralez approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add flake8 to the lint task?

@jameslamb jameslamb mentioned this pull request Nov 2, 2022
Closed
3 tasks
@jameslamb
Copy link
Collaborator Author

Do you think we should add flake8 to the lint task?

I do! I've found it really valuable in the projects I've used it on. I opened #5566 to discuss it.

@jameslamb jameslamb merged commit 0c5f46f into master Nov 4, 2022
@jameslamb jameslamb deleted the unused-imports branch November 4, 2022 01:10
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmoralez jmoralez jmoralez approved these changes

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @jmoralez