Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] add type hints on sklearn properties #5771

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to #3756.
Contributes to #3867.

Proposes adding type annotations on the remaining sklearn properties that don't have them.

Notes for Reviewers

This introduces a few new mypy errors, like this:

python-package/lightgbm/sklearn.py:979: error: Item "None" of "Optional[Booster]" has no attribute "feature_importance" [union-attr]
python-package/lightgbm/sklearn.py:986: error: Item "None" of "Optional[Booster]" has no attribute "feature_name" [union-attr]

Those are caused by the fact that some of these attributes are initialized to None and we know they'll be non-None is self.__sklearn_is_fitted__() is True...but mypy is rightly saying "hey as far as I know, this could be None at this point".

I'd like to propose fixes for those in a follow-up PR, so we can continue the conversation from #4837 (comment) there.

@jameslamb jameslamb merged commit f585eaf into master Mar 9, 2023
@jameslamb jameslamb deleted the ci/mypy-sklearn-property-hints branch March 9, 2023 04:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants