[python-package] add type hints on sklearn properties #5771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
Contributes to #3867.
Proposes adding type annotations on the remaining sklearn properties that don't have them.
Notes for Reviewers
This introduces a few new
mypy
errors, like this:Those are caused by the fact that some of these attributes are initialized to
None
and we know they'll be non-None
isself.__sklearn_is_fitted__()
isTrue
...butmypy
is rightly saying "hey as far as I know, this could beNone
at this point".I'd like to propose fixes for those in a follow-up PR, so we can continue the conversation from #4837 (comment) there.