[python-package] consolidate pandas-to-numpy conversion code #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
shiyu1994 and
jmoralez
as code owners
jmoralez
reviewed
Nov 6, 2023
jmoralez
approved these changes
Nov 7, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
#5612 introduced a
try-catchblock with different approaches to converting array data frompandastonumpyformat inside the Python package.That PR added 2 identical copies of that block in the 2 places where
lightgbmneeds to do that conversion.This PR proposes consolidating that logic into a single internal function. To make
basic._data_from_pandas()a bit easier to understand, and to reduce the risk of inconsistencies if additional branches of logic are added in response to futurepandasversions.