[R-package] change CRAN maintainer #6224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5987.
Contributes to #6221.
Will help with the v4.2.0 release (#6191).
Proposes changing the maintainer ("cre") for the R package from @shiyu1994 to me.
I'd asked about this a few times, most recently in #6221 (comment), but we've never really discussed it. I'm opening this PR as a place to have that discussion.
What does this mean?
This would mean that the following feedback from CRAN all go to my personal email, instead of @shiyu1994 's work email:
As described in https://cran.r-project.org/doc/manuals/R-exts.html#The-DESCRIPTION-file
More descriptions on the role can be found in https://journal.r-project.org/archive/2012-1/RJournal_2012-1_Hornik~et~al.pdf.
Why do this?
Removes friction in the process of releasing the R package and reduces the risk of incidents like #4713 where
{lightgbm}
is removed from CRAN due to issues detected there + our response not being fast enough.For most practical purposes, I have been the primary maintainer for the R package here fore the last 2+ years.
The process for releasing has been:
If I were CRAN's primary contact for the package, it would make this cycle faster. There would be no need for a separate waiting period for clicking that approval link, for example.
Is this allowed by Microsoft?
It should be. The
{finnts}
project from Microsoft, for example, hasMaintainer
set to a GMail account, not a Microsoft employee email.https://github.com/microsoft/finnts/blob/37e6fb8bced45b18c0fac14b0374612f12f4f855/DESCRIPTION#L5-L9
https://cran.r-project.org/web/packages/finnts/index.html
Is this allowed by CRAN?
Absolutely. We changed the maintainer from @guolinke to @shiyu1994 back in #4633 and that change was allowed.
As described in https://cran.r-project.org/web/packages/policies.html#Submission
Notes for Reviewers
Thanks for your time and consideration.
And especially to you @shiyu1994 ... please don't think of this PR as a criticism. I am just trying to do what I can to keep
{lightgbm}
on CRAN, and to reduce a source of work for you, as I know you're quite busy. Thanks as always for your help!I won't merge this without approvals from all of @shiyu1994 @guolinke and @jmoralez .