-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] remove pmml redirect, simplify some other docs #6490
Conversation
@@ -156,8 +156,6 @@ Qi Meng, Guolin Ke, Taifeng Wang, Wei Chen, Qiwei Ye, Zhi-Ming Ma, Tie-Yan Liu. | |||
|
|||
Huan Zhang, Si Si and Cho-Jui Hsieh. "[GPU Acceleration for Large-scale Tree Boosting](https://arxiv.org/abs/1706.08359)". SysML Conference, 2018. | |||
|
|||
**Note**: If you use LightGBM in your GitHub projects, please add `lightgbm` in the `requirements.txt`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added back in #2192, around when GitHub first added the Used By
metric (#2192 (comment)) that you can view on the repo homepage.

I think having it here could be confused as a documentation of how to use the project, and that it should be removed to simplify the instructions a bit.
@@ -11,8 +11,6 @@ Preparation | |||
|
|||
32-bit Python is not supported. Please install 64-bit version. If you have a strong need to install with 32-bit Python, refer to `Build 32-bit Version with 32-bit Python section <#build-32-bit-version-with-32-bit-python>`__. | |||
|
|||
`setuptools <https://pypi.org/project/setuptools>`_ is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer true, as of #5837
Appveyor CI is failing across several PRs, like this:
There WAS a new BUT... the Appveyor jobs should be using only Python 3.8 Lines 5 to 6 in 7d33879
so it's surprising to see Python 3.7 being pulled in:
And Python 3.7 being pulled in is what's causing this error. I suspect that what's happening here is:
Lines 47 to 49 in 7d33879
We should probably update |
looks like setting updating the Python version at the same time that we update I'll merge this to unblock CI. |
I'm planning to invest heavily in the project's documentation for the next release. I think there are some opportunities to make things simpler and to make it more likely that people are able to find the information they need without turning to Stack Overflow or the issues pages.
This proposes the following:
pmml/
folder