Update README.md #21
Closed
Update README.md #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: yes fixes #19 @JoshuaElsdon |
|
Hey thanks for the contribution! I agree we could be clearer about the git-lfs requirement. It was only called out explicitly in the demo readme file. (example.md). I think for completeness it would be better to link to https://git-lfs.com/ rather than provide line by line examples that are specific to linux, this way we can cover the installation for all OSes without making the readme difficult to parse. The pull on git-lfs submodules should not be needed. Init followed by update should get all the files. I will modify your contribution and test it on a clean machine. |
|
I'll be closing this pr. Thanks! |
|
An equivalent change has been merged into main now. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clearly mention how to download the models from git lfs.
probably fixes #19
Following the previous instructions never downloaded models. It was just downloading pointers to the large files stored on git lfs. Hope this fixes it.