Only print evaluate requests in REPL context #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
force-pushed
the
dev/waan/evaluateOutputREPL
branch
from
bbbdb86 to
b49b232
Compare
This PR checks to see if the `-exec` commands are originally from the REPL context (e.g. the Debug Console). If so, it will redirect the output of the -exec command to the REPL window. If it is another context, it will not print anything.
andrewcrawley
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the EvaluateRequest with an
-execcommand and assign the return protocol with the correctValue.This causes the DebugConsole in VS Code to show the output as a REPL output instead of an engine output.
Old:
New:
Fixes: #1236