Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Actions and Fix Build Warnings #1394

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Update Actions and Fix Build Warnings #1394

merged 1 commit into from
Apr 5, 2023

Conversation

WardenGnaw
Copy link
Member

This PR update the GitHub action tasks that are warning due to node-12 being outdated and cleaing up some C# warnings.
The tasks are:

  • checkout v3
  • setup-dotnet v3
  • setup-msbuild v1.1
  • Setup-VSTest v1.2
  • upload-artifact v3

Also addrssed hardcoded strings that were the same name as the variable name that appeared as warnings.

This PR update the GitHub action tasks that are warning due to node-12
being outdated and cleaing up some C# warnings.
The tasks are:
- checkout v3
- setup-dotnet v3
- setup-msbuild v1.1
- Setup-VSTest v1.2
- upload-artifact v3

Also addrssed hardcoded strings that were the same name as the variable
name that appeared as warnings.
@WardenGnaw WardenGnaw self-assigned this Apr 5, 2023
@WardenGnaw
Copy link
Member Author

CppTests.Tests.SampleTests.TestFolderol is flaky. Ignoring test failure.

@WardenGnaw WardenGnaw merged commit 17d1252 into main Apr 5, 2023
@WardenGnaw WardenGnaw deleted the dev/waan/cleanup branch April 5, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants