Align use of sendInvalidate request arguments #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sendInvalidate request arguments now behave like invalidate event. - Areas is an array of strings. - Areas can be empty, in this case client should assume 'all'.
|
Tagging @WardenGnaw since they reviewed the original sendInvalidate request pr. |
WardenGnaw
reviewed
May 30, 2023
Allow sending an empty array of Areas. Co-authored-by: Andrew Wang <waan@microsoft.com>
Use Collection instead of List Co-authored-by: Andrew Wang <waan@microsoft.com>
WardenGnaw
approved these changes
Jun 28, 2023
|
@iAbadia Thank you for contributing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
sendInvalidaterequest I realised that I was forced to provide a singleAreaas an argument. This PR aligns the behaviour ofsendInvalidaterequest with theinvalidateevent.Thanks to @sbobko for his original contribution, I only hope this patch doesn't contradict the original intent of the behaviour of
sendInvalidate