Only use ps 'flags' for macOS #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds in an operating system check via uname to determine if we should run the PS command with the 'flags' flag. This feature was originally used to determine the architecture of a process for macOS M1 machines that can run as x64 or as arm64. AD7Process only uses the flags field in macOS so this PR updates the command sent to only use it on macOS machines. Other changes: - Updated the setup.csx script to update VS with VS.list instead of VS.Codespaces.list - Updated tests to use the new PSOutputParser - Added a macOS test
CarlosGuerraVz
approved these changes
Aug 7, 2023
gregg-miskelly
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in an operating system check via uname to determine if we should run the PS command with the 'flags' flag. This feature was originally used to determine the architecture of a process for macOS M1 machines that can run as x64 or as arm64.
AD7Process only uses the flags field in macOS so this PR updates the command sent to only use it on macOS machines.
Other changes:
Testing: