Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing File writing for EngineLogger #1415

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Fixing File writing for EngineLogger #1415

merged 2 commits into from
Aug 18, 2023

Commits on Aug 15, 2023

  1. Fixing File writing for EngineLogger 

    With the Natvis Diagnostics Logger work, the file logger would fail
since it would not close the file.

This PR also runs 'File.CreateText' in MIDebugCommandDispatcher so
errors can be caught earlier and not set an invalid file path.
    @WardenGnaw
    WardenGnaw committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e6d0ec0 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Add error if Debug session is running

    @WardenGnaw
    WardenGnaw committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7b1bad9 View commit details
    Browse the repository at this point in the history