Fix for Issue #844 where pause does not work on Linux and Mac when using gdbservers #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnected' message
Again, pulling from MiEngine/master
|
|
pieandcakes
reviewed
May 7, 2019
pieandcakes
reviewed
May 7, 2019
pieandcakes
requested review from
pieandcakes,
paulmaybee,
gregg-miskelly and
WardenGnaw
|
@haneefdm Thank you for submitting this! |
|
resolves #844 |
…n same thing as before
gregg-miskelly
approved these changes
May 9, 2019
|
@pieandcakes Do you have any additional comments? @paulmaybee Do you want to review this since it touches some features that you added? |
pieandcakes
approved these changes
May 9, 2019
paulmaybee
approved these changes
May 14, 2019
|
@haneefdm Thanks again for submitting this! |
|
Thank you all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways of having local gdb but running with a gdbserver. You can either use the
miDebuggerServerAddressordebugServerPathin launch configuration. Most of us thedebugServerPathto start and end the server with the debug session because of additional configuration that is needed to get the server running properly.When using a gdbserver, the logic was wrong for the case of
debugServerPathon linux/Mac and we did kill a process that was not running locally -- ending up potentially killing a random process.The fix is to treat
miDebuggerServerAddressanddebugServerPathsimilarly. I refactored some code and put into a single functionIsLocalLaunchUsingServer()as this kind of logic was used in multiple places. I also found that the checks for the use of these properties were inconsistent. Sometimes it wasstring. IsNullOrWhiteSpace()and sometimesstring. IsNullOrEmpty(). Now, they are allIsNullOrWhiteSpace()for these two options.I renamed two methods IsLocalGdb and IsRemoteGdb to be more meaningful. Add a 'Target' suffix to them
Here is my testing matrix.
Basically, I had to test on all three platforms in multiple configurations. Many fails turned into passes with these changes.
My first PR so, let me know if I missed anything. I could not run the CodeFormatter.exe -- it was crashing due to a missing dll, but I formatted my changes with the VStudio editor.
In the process of this, I found a couple more issues but I want to treat them as separate things. I documented them in my 'testing matrix' link above.