Revert "add quantized values to the default tunable groups fixture"

This reverts commit cdd71e1.
microsoft · Jul 23, 2024 · 1c2eaf2 · 1c2eaf2
1 parent 828e87c
commit 1c2eaf2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/mlos_bench/mlos_bench/tests/optimizers/toy_optimization_loop_test.py b/mlos_bench/mlos_bench/tests/optimizers/toy_optimization_loop_test.py
@@ -113,7 +113,7 @@ def test_smac_optimization_loop(mock_env_no_noise: MockEnv, smac_opt: MlosCoreOp
  "vmSize": "Standard_B2s",
  "idle": "mwait",
  "kernel_sched_migration_cost_ns": 297669,
- "kernel_sched_latency_ns": 290365100,
+ "kernel_sched_latency_ns": 290365137,
  }
  assert score == pytest.approx(expected_score, 0.01)
  assert tunables.get_param_values() == expected_tunable_values
diff --git a/mlos_bench/mlos_bench/tests/tunable_groups_fixtures.py b/mlos_bench/mlos_bench/tests/tunable_groups_fixtures.py
@@ -15,6 +15,8 @@
 
 # pylint: disable=redefined-outer-name
 
+# TODO: Add quantized tunables here for better test coverage.
+
 TUNABLE_GROUPS_JSON = """
 {
  "provision": {
@@ -60,8 +62,7 @@
  "type": "int",
  "default": 2000000,
  "range": [0, 1000000000],
- "log": false,
- "quantization": 100
+ "log": false
  }
  }
  }

diff --git a/mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py b/mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py
@@ -63,7 +63,6 @@ def configuration_space() -> ConfigurationSpace:
  spaces[kernel_sched_migration_cost_ns_type].default_value = TunableValueKind.SPECIAL
  spaces[kernel_sched_migration_cost_ns_type].probabilities = (0.5, 0.5)
  spaces["kernel_sched_latency_ns"].default_value = 2000000
- spaces["kernel_sched_latency_ns"].q = 100
 
  spaces.add_condition(
  EqualsCondition(