Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Gaussian Blob With Context into an ObjectiveFunction #207

Closed
byte-sculptor opened this issue Dec 11, 2020 · 1 comment
Closed

Turn Gaussian Blob With Context into an ObjectiveFunction #207

byte-sculptor opened this issue Dec 11, 2020 · 1 comment

Comments

@byte-sculptor
Copy link
Contributor

A Gaussian Blobl is used in test_optimization_with_context right now but it's an unstable test and it's unclear why. Pulling Gaussian Blob as a separate objective function would allow us to inspect it thoroughly using the OptimizerEvaluator and all the other tools. Not to mention that it would become one of our standard workloads for the evaluation framework.

@bpkroth
Copy link
Contributor

bpkroth commented Dec 11, 2020

For the record, one of the goals of doing this would be to gain some confidence that the fix we applied in #206 (n_samples = 5000) is a good one.

byte-sculptor added a commit that referenced this issue Dec 11, 2020
1. Invokes pytest with a `-n auto` argument to make multiple tests run in parallel (num parallel jobs = num cores)
2. Installs pytest-xdist in all our pipelines to make the above possible
3. Shortens the duration of TestOptimizerEvaluator
4. Modifies the tests that use gRPC to attempt to start the service on 100 different ports before giving up. This is the easiest way to make sure that all tests requiring gRPC can run in parallel. The alternative would be to have them all talk to a single instance, but it would turn an easy parallelization problem into a hard one as we'd need to manage the lifetime of that single instance.
5. Relaxes the check in TestSmartCacheWithRemoteOptimizerV3.py as the current one was a bit too ambitious and lead to some flakiness.
6. Puts a band-aid on test_optimization_with_context. #207 hints at a long-term fix.

Co-authored-by: Adam Śmiechowski <adsmiech@microsoft.com>
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@bpkroth bpkroth closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants