Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage checks #33

Closed
bpkroth opened this issue Sep 2, 2020 · 3 comments · Fixed by #279
Closed

Add code coverage checks #33

bpkroth opened this issue Sep 2, 2020 · 3 comments · Fixed by #279

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Sep 2, 2020

Breaking out from #6:

It would be good to add code coverage checks and badges for that to the repo landing pages.
@amueller
Copy link
Contributor

using https://github.com/codecov/codecov-action
and https://www.codecov.io/ ?

@bpkroth
Copy link
Contributor Author

bpkroth commented Sep 15, 2020

That works for me. It's what hummingbird uses as well:
https://github.com/microsoft/hummingbird/blob/b8332d12fc82c1c9137a09e69776a1555da0176a/.github/workflows/pythonapp.yml#L75

@bpkroth bpkroth mentioned this issue Nov 12, 2020
Merged
@amueller
Copy link
Contributor

I wonder who recommended it to them ;)

@bpkroth bpkroth mentioned this issue Nov 20, 2020
Merged
@bpkroth bpkroth mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce minimum code coverage bpkroth/MLOS
2 participants
@amueller @bpkroth