first shot at adding ~coveralls~ codecov integration #187
Conversation
amueller
changed the title
| @@ -175,6 +175,7 @@ RUN python3.7 -m pip install pip && \ | |||
| COPY ./source/Mlos.Python/requirements.txt /tmp/ | |||
| RUN python3.7 -m pip install -r /tmp/requirements.txt | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Or do we need pip install pytest-cov?
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage ? 79.28%
=======================================
Files ? 168
Lines ? 9457
Branches ? 0
=======================================
Hits ? 7498
Misses ? 1959
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
right now the PR coverage diff isn't working because there's no coverage for the base branch. So I think we should merge so that we can get coverage for that? I have to see how to enable it as a CI check, but we already have file-level coverage for this PR: https://codecov.io/gh/microsoft/MLOS/pull/187/tree?path=source%2FMlos.Python%2Fmlos |
|
Not sure if you can see it, but in the settings here: it tells me to enable something in the MS org which I don't have access to :-/ |
No, I get a "sorry you don't have access to this", but I didn't try very hard ... We should check with @ksaur about what they did for the hummingbird repo. |
|
Related: #33 (though perhaps not all of it) |
|
@bpkroth Hmm....I don't remember having to enable something special. Ping me tomorrow and we can try to troubleshoot. (I just checked that I can verify that link above if I |
|
btw looks like we don't need to have a yaml file: When I go to the config page, at the top it says "Github Integration is installed. However, this repository is not enabled.". |
|
I still think we should merge this as a first pass btw. |
|
Do you want to add a badge to the front page, or leave that for later? |
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
- Increase the timeouts on the pytest runs. There have been some timeouts recently, due in part to the addition of code coverage tracking (microsoft#187). - Separate the pylint checks (short) from the pytest runs (long, flaky) so that we can have the docker image publish task proceed in nightly runs even if the pytest run was flaky.
* Tweaks to Python Test CI pipelines - Increase the timeouts on the pytest runs. There have been some timeouts recently, due in part to the addition of code coverage tracking (#187). - Separate the pylint checks (short) from the pytest runs (long, flaky) so that we can have the docker image publish task proceed in nightly runs even if the pytest run was flaky. * Avoid duplicate ctest runs during Github CI runs Fixes #196 * pass the GITHUB_WORKFLOW env var through the docker process * fixup argument order
No description provided.