Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cake build runs unit tests twice #196

Closed
bpkroth opened this issue Dec 2, 2020 · 0 comments · Fixed by #198
Closed

Cake build runs unit tests twice #196

bpkroth opened this issue Dec 2, 2020 · 0 comments · Fixed by #198
Assignees
@bpkroth

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Dec 2, 2020 •
edited
Loading 

Task("Default")
    .IsDependentOn("Test-CMake")             // Does the same thing as Run-CMake-UnitTest via ctest
    .IsDependentOn("Run-NetCore-UnitTests")
    .IsDependentOn("Run-CMake-UnitTests")    // Does the same thing as Run-MSBuild-UnitTests via dotnet build Mlos.TestRun.proj
    .IsDependentOn("Run-MSBuild-UnitTests")
    .IsDependentOn("Generate-MlosModelServices-Dockerfile");

@grlap I'd like to comment out one of these. Do you have a preference on which one should remain?
@bpkroth bpkroth self-assigned this Dec 2, 2020
bpkroth added a commit to bpkroth/MLOS that referenced this issue Dec 2, 2020
@bpkroth
Avoid duplicate ctest runs during Github CI runs
0ccfabf 
Fixes microsoft#196
@bpkroth bpkroth linked a pull request Dec 2, 2020 that will close this issue
Tweaks to Python Test CI pipelines #198
Merged
bpkroth added a commit that referenced this issue Dec 2, 2020
@bpkroth
Tweaks to Python Test CI pipelines (#198)
27c39e7 
* Tweaks to Python Test CI pipelines

- Increase the timeouts on the pytest runs.
  There have been some timeouts recently, due in part to the addition of code
  coverage tracking (#187).

- Separate the pylint checks (short) from the pytest runs (long, flaky) so that
  we can have the docker image publish task proceed in nightly runs even if the
  pytest run was flaky.

* Avoid duplicate ctest runs during Github CI runs

Fixes #196

* pass the GITHUB_WORKFLOW env var through the docker process

* fixup argument order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpkroth bpkroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweaks to Python Test CI pipelines bpkroth/MLOS
1 participant
@bpkroth