Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp number of iterations vs. number of configs tracking #715

Closed
4 tasks done
bpkroth opened this issue Mar 15, 2024 · 1 comment
Closed
4 tasks done

Revamp number of iterations vs. number of configs tracking #715

bpkroth opened this issue Mar 15, 2024 · 1 comment
Assignees

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Mar 15, 2024

Discussed offline:

Originally posted by @bpkroth in #710 (comment)

motus added a commit that referenced this issue Mar 19, 2024
….suggest()` instead of `.register()` (#713)

makes optimizers and schedulers a bit simpler. Part of issue #715 

Closes #711 

Note: the move from `--max_iterations` to `--max_suggestions` is a
breaking change, so we will need to cut a new release for this.

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
motus added a commit that referenced this issue Mar 19, 2024
maybe merge after #713 (they might conflict)

Part of issue #715

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus
Copy link
Member

motus commented Mar 19, 2024

I think we've fixed this one in #713 and #719

@motus motus closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants