Initial work to add gcc support #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't work as is since it attempts to redefine the target upon every sub-project include. At the moment we use uncrustify anyways.
Started as a hack to workaround cmake's FetchContent not appearing to pass the CMAKE_COMPILER_ID through when building with CXX=clang++-10 This also fixes a few minor issues that gcc complained about. TODO: - [ ] Enable CI pipeline tests
bpkroth
commented
Nov 13, 2020
|
Per discussion with @grlap, the other (better) approach that I was originally thinking to remove the duplicate definitions by splitting the the declaration from the definition should also be possible. |
bpkroth
commented
Nov 14, 2020
also shorten the name of the attr macro
... to something that gcc in Ubuntu 16.04 can use
Closed
|
Note: since this adds new build jobs to the pipelines, we'll need to change the CI requirements to let this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to enable gcc support #23
Started as a hack to workaround cmake's FetchContent not appearing to pass the CMAKE_COMPILER_ID through when building with CXX=clang++-10
This also fixes a few minor issues that gcc complained about.