Avoid some broken cmake package versions in Docker image build #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
Nov 19, 2020
bpkroth
commented
Nov 19, 2020
bpkroth
commented
Nov 19, 2020
|
|
||
| sudo tee /etc/apt/preferences.d/avoid-broken-cmake-repo-package-versions <<'APT_PREFERENCES' | ||
| Package: cmake | ||
| Pin: version 3.19.0-0kitware1ubuntu20.04.1 |
There was a problem hiding this comment.
This version doesn't actually exist in the upstream repos yet.
When it does, this problem will go away.
In the meantime however, we still want to install the previous version of cmake (3.18.4...). For that to work we need to rejectlist the higher version of cmake-data.
With that in place, when the version above of cmake appears it will depend on the corresponding version of cmake-data, which we would have rejectlisted, causing a new but related error.
Thus, for now, we simply rejectlist both of them.
amueller
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the cmake apt repo we rely on has published newer cmake packages that specify a dependency that doesn't exist. This breaks a clean cmake install (as we do during docker image build).
For the moment, we're adding that version to a rejectlist to workaround the issue.