Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename test class to start with Test so pytest finds them #186

Merged
merged 2 commits into from
Nov 19, 2020
Merged

rename test class to start with Test so pytest finds them #186

merged 2 commits into from
Nov 19, 2020

Conversation

amueller
Copy link
Contributor

Fixes #178.

It's unclear to me whether unittest ran these. But they pass ;)

@amueller
Copy link
Contributor Author

FYI I was looking at the coverage output which you can get with
pytest --cov-report html --cov=mlos source/Mlos.Python

@bpkroth bpkroth self-requested a review November 19, 2020 19:13
bpkroth
bpkroth approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amueller amueller merged commit b2e16cb into microsoft:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

@byte-sculptor byte-sculptor byte-sculptor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pytest test match
3 participants
@amueller @bpkroth @byte-sculptor