Refactor config examples directory structure #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is in preparation for my SSH PR so I have a reasonable place to put those config/script snippets. |
|
Absolute nit, but it bugs me: Or Anyways, we're pretty inconsistent about pluralized names. |
bpkroth
commented
Apr 25, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
bpkroth
commented
May 3, 2023
This was referenced May 3, 2023
|
[like] Brian Kroth (GSL) reacted to your message:
________________________________
From: Sergiy Matusevych ***@***.***>
Sent: Wednesday, May 3, 2023 10:10:05 PM
To: microsoft/MLOS ***@***.***>
Cc: Brian Kroth (GSL) ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/MLOS] Refactor config examples directory structure (PR #313)
@motus commented on this pull request.
________________________________
In mlos_bench/mlos_bench/config/service/remote/azure/service-provision-vm.jsonc<#313 (comment)>:
@@ -4,7 +4,7 @@
"config": {
- "deployTemplatePath": "azure/arm-templates/azuredeploy-ubuntu-vm.jsonc",
+ "deployTemplatePath": "service/remote/azure/vm/arm-templates/azuredeploy-ubuntu-vm.jsonc",
agree. I've been thinking about relative paths but also decided to put it off for a while. Let's live with what we have now and can focus on running the experiments
—
Reply to this email directly, view it on GitHub<#313 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQ53FC45BO57XEIZ6N6MMDXELJT3ANCNFSM6AAAAAAXKFZQUQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
motus
approved these changes
May 3, 2023
mlos_bench/mlos_bench/tests/config/environments/test_load_environment_config_examples.py
Show resolved
Hide resolved
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing configs and examples directory structure is a little bit of a mess and not currently being distributed with the
whl.This PR starts reorganizing it to
servicevs.environmentvs.optimizervs.storagebase classes).whlimportlibto access files at runtime for the default search path:https://setuptools.pypa.io/en/latest/userguide/datafiles.html#accessing-data-files-at-runtime
configdir and check that we can at least load them into an Environment class.TunableGroupsloading logic also needing fixing and tests - Fixes for TunableGroups merging logic #327This should make it easier to interact with and test the pre-canned examples.
Future work:
jsonschemafor config validation and IDE autocomplete help