Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flake8, mypy, and pylint issues #354

Merged
merged 2 commits into from
May 15, 2023
Merged

fix flake8, mypy, and pylint issues #354

merged 2 commits into from
May 15, 2023

Conversation

motus
Copy link
Member

@motus motus commented May 11, 2023

cosmetic fixes:

  • unused imports
  • circular imports
  • missing/incorrect type annotations
  • duplicated code
  • etc.

@motus motus requested a review from a team as a code owner May 11, 2023 21:02
@motus motus enabled auto-merge (squash) May 11, 2023 21:02
@motus motus mentioned this pull request May 13, 2023
Merged
bpkroth
bpkroth approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I may add flake8 and/or prettier to the devcontainer setup so we always get that.

@motus motus merged commit 899f215 into microsoft:main May 15, 2023
@bpkroth bpkroth mentioned this pull request May 15, 2023
Closed
@motus motus deleted the motus/flake8/fix branch May 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motus @bpkroth