mlos_bench config json schema validation - environments #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- can stage more later
bpkroth
commented
May 18, 2023
mlos_bench/mlos_bench/config/schemas/environments/local/local-fileshare-env-subschema.json
Show resolved
Hide resolved
bpkroth
commented
May 18, 2023
mlos_bench/mlos_bench/config/schemas/environments/local/local-env-subschema.json
Show resolved
Hide resolved
…e in having an empty config block)
bpkroth
changed the title
8 tasks
bpkroth
commented
May 19, 2023
mlos_bench/mlos_bench/tests/config/schemas/optimizers/test_optimizer_schemas.py
Outdated
Show resolved
Hide resolved
bpkroth
commented
May 19, 2023
3 tasks
motus
approved these changes
May 19, 2023
mlos_bench/mlos_bench/tests/config/schemas/environments/test_environment_schemas.py
Outdated
Show resolved
Hide resolved
bpkroth
added a commit
that referenced
this pull request
May 22, 2023
Extends #340, #346, #349, #352, #359 to Service configs. See Also: #331 - [x] main schema as a set of subschemas - [x] connect schema validation in the mlos_bench code - [x] test-cases To do this we removed support for configs that were flat lists of service configs: `[ {"class": "service.class"} ]` and turned those into objects that have a single key `"services"` with the list instead. `{ "services": [ ... ] }` This makes sure that all configs are dicts/objects that we can optionally put `"$schema"` attributes on but also simplifies some of the config loading logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #340, #346, #349, #352 to Environment configs.
See Also: #331