Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Control Plane RG Setup #480

Merged
merged 23 commits into from
Sep 6, 2023

Conversation

eujing
Copy link
Contributor

@eujing eujing commented Aug 9, 2023

This PR adds an initial script for automating the set up of the control plane resource group.
More details in the included README.

@eujing eujing requested a review from a team as a code owner August 9, 2023 23:42
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
@bpkroth bpkroth changed the title Automate RG setup Automate Control Plane RG Setup Aug 16, 2023
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
scripts/setup-rg/README.md Outdated Show resolved Hide resolved
@eujing eujing requested a review from bpkroth August 31, 2023 21:17
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Let's fix the remaining CI issues and get it in. We can fix additional bugs/improvements in future PRs.

@bpkroth
Copy link
Contributor

bpkroth commented Sep 5, 2023

Have a look here for excluding your new arm template json configs from schema checking.

def filter_configs(configs_to_filter: List[str]) -> List[str]:
"""If necessary, filter out json files that aren't for the module we're testing."""
for config_path in configs_to_filter:
if config_path.endswith("arm-templates/azuredeploy-ubuntu-vm.jsonc"):
configs_to_filter.remove(config_path)
return configs_to_filter

@eujing
Copy link
Contributor Author

eujing commented Sep 6, 2023

Have a look here for excluding your new arm template json configs from schema checking.

def filter_configs(configs_to_filter: List[str]) -> List[str]:
"""If necessary, filter out json files that aren't for the module we're testing."""
for config_path in configs_to_filter:
if config_path.endswith("arm-templates/azuredeploy-ubuntu-vm.jsonc"):
configs_to_filter.remove(config_path)
return configs_to_filter

Got it! I had to change the filtering away from in-place removing as I was getting some issues with removed paths still appearing in the list during iteration.

@bpkroth bpkroth enabled auto-merge (squash) September 6, 2023 20:23
@bpkroth bpkroth merged commit 20e72f4 into microsoft:main Sep 6, 2023
11 checks passed
@bpkroth bpkroth mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants