-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Control Plane RG Setup #480
Conversation
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/rg-template.json
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.sh
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.sh
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.sh
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.sh
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.sh
Outdated
Show resolved
Hide resolved
mlos_bench/mlos_bench/config/services/remote/azure/scripts/setup-rg/setup-rg.ps1
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Let's fix the remaining CI issues and get it in. We can fix additional bugs/improvements in future PRs.
Have a look here for excluding your new arm template json configs from schema checking. MLOS/mlos_bench/mlos_bench/tests/config/services/test_load_service_config_examples.py Lines 28 to 33 in 6997c2a
|
Got it! I had to change the filtering away from in-place removing as I was getting some issues with removed paths still appearing in the list during iteration. |
This PR adds an initial script for automating the set up of the control plane resource group.
More details in the included README.