Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups to commit message checks to only happen during PR pushes #509

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Fixups to commit message checks to only happen during PR pushes #509

merged 8 commits into from
Sep 18, 2023

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Sep 18, 2023

Handles bugs from #508.

Also try and fix a quoting issues.

@bpkroth bpkroth requested a review from a team as a code owner September 18, 2023 19:28
@bpkroth bpkroth marked this pull request as draft September 18, 2023 19:29
@bpkroth bpkroth marked this pull request as ready for review September 18, 2023 19:42
@bpkroth bpkroth enabled auto-merge (squash) September 18, 2023 19:42
@bpkroth bpkroth added the ready for review Ready for review label Sep 18, 2023
motus
motus approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@bpkroth bpkroth merged commit 0b0842f into microsoft:main Sep 18, 2023
@bpkroth bpkroth mentioned this pull request Sep 19, 2023
Merged
bpkroth added a commit to bpkroth/MLOS that referenced this pull request Sep 19, 2023
@bpkroth
Fixups to commit message checks to only happen during PR pushes (micr…
b581210 
…osoft#509)

Handles bugs from microsoft#508.

Also try and fix a quoting issues.
bpkroth added a commit that referenced this pull request Sep 20, 2023
@bpkroth
No cache support for manual devcontainer build triggers (#511)
de99169 
One more minor tweak on #509 and #508. This allows us to force a rebuild
of the devcontainer with NO_CACHE=true manually without needing to push
an empty commit.
@bpkroth bpkroth deleted the ci-fixups-2 branch October 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @motus