Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#628 mistakenly included an early attempt at adding
optimization_target
andoptimization_direction
to theexperiment
table in themlos_bench.storage.sql
backend.In that PR we later moved it to its own
objectives
table to eventually support multi-objectives.Nothing accesses those columns now, however including them in the metadata makes it impossible to load storage backends previously created with the old schema since adjusting columns with sqlalchemy's
create_all()
API only considers table existence.On the contrary, the latter means that we will automatically support old storage backends with the new code for the
objectives
table.Removing these two columns in the
metadata
schema description simply allows that to proceed without error.See Also: #649