Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mistakenly added columns #652

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Jan 26, 2024

#628 mistakenly included an early attempt at adding optimization_target and optimization_direction to the experiment table in the mlos_bench.storage.sql backend.

In that PR we later moved it to its own objectives table to eventually support multi-objectives.

Nothing accesses those columns now, however including them in the metadata makes it impossible to load storage backends previously created with the old schema since adjusting columns with sqlalchemy's create_all() API only considers table existence.

On the contrary, the latter means that we will automatically support old storage backends with the new code for the objectives table.

Removing these two columns in the metadata schema description simply allows that to proceed without error.

See Also: #649

@bpkroth bpkroth requested a review from a team as a code owner January 26, 2024 18:20
@bpkroth bpkroth added bug Something isn't working ready for review Ready for review labels Jan 26, 2024
@motus motus enabled auto-merge (squash) January 26, 2024 22:55
@motus motus merged commit 5be96f2 into microsoft:main Jan 26, 2024
11 checks passed
@bpkroth bpkroth deleted the mlos-bench/storage-schema-fixup branch February 27, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants