Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups and testing for cli config file parsing #722

Merged
merged 17 commits into from
Jul 23, 2024
Merged

Fixups and testing for cli config file parsing #722

merged 17 commits into from
Jul 23, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Mar 21, 2024

Further fixups to #717

Some parameters were not being respected from --config test-cli-config.jsonc files.

Split out from #720

@bpkroth bpkroth marked this pull request as ready for review March 21, 2024 20:58
@bpkroth bpkroth requested a review from a team as a code owner March 21, 2024 20:58
@bpkroth bpkroth marked this pull request as draft March 21, 2024 21:14
@bpkroth bpkroth added the WIP Work in progress - do not merge yet label Mar 21, 2024
@bpkroth bpkroth marked this pull request as ready for review July 22, 2024 20:27
motus
motus requested changes Jul 22, 2024
View reviewed changes
mlos_bench/mlos_bench/launcher.py Outdated Show resolved Hide resolved
@motus motus enabled auto-merge (squash) July 23, 2024 21:21
@motus motus disabled auto-merge July 23, 2024 21:22
@motus motus merged commit 7dce3d1 into microsoft:main Jul 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
WIP Work in progress - do not merge yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @motus