Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable context for SMAC Optimizer #741
Enable context for SMAC Optimizer #741
Changes from 49 commits
4b325b4
a59a499
14c80d9
d2b4c9b
1d8b455
266d30c
7d57cf5
65e2170
c330be9
891c755
2693d2d
ba7b975
708e9a3
78fc91e
79b9ed0
d2bc22c
65dc1b7
c92924c
f48f65f
5469503
e3c238b
4bc55ee
311175a
9899089
ea391c7
17a5965
d8fe76e
cd3913f
a5f3ce7
546cb35
17ae308
12d725c
ee99fd5
57103f5
3d57a10
02b8b9d
465dc69
0d48d5e
c19d4c7
3841b42
23b1a83
d047836
96198d9
77b46ee
f3773ea
f45279b
4f3101d
6725d74
9d5f973
dab5c67
f70eacf
8faf321
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and everywhere: let's separate cosmetic fixes from functional changes. mixing the two bloats up the diff and makes reviewing PRs much harder. Please keep the essential functionality in this PR and make the diff as small as possible and move all code annotations, style, and docstring improvements to a separate PR. having more PRs is good for your github karma! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! #744 should do just the style changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, @motus @jsfreischuetz and I already talked about that. #744 is the start of that, but I think will also need some additional work. #746 unearthed some related topics around
pyproject.toml
settings vs.setup.cfg
for usingblack
and howsetup
andbuild
type dependencies are specified (right now we requireconda
for certain ones instead ofpip
, which as we saw, has some issues).Am currently working on improvements for all of those and will send a split out series of PRs soon for:
black
andisort
Makefile
rules,vscode
settings, configs, etc..gitrevisions
list to ignore it from mostgit blame
types of analysisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a whole bunch of style-only changes in here that makes reviewing a little difficult.
Can you please revert those, or separate them out to a different PR?