-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pyproject.toml build changes #764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve changed since the last successful build. This should help improve incremental rebuilds in dev loops.
bpkroth
force-pushed
the
pyproject-toml-build-changes
branch
from
June 28, 2024 17:58
9e5e239
to
ebdd526
Compare
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
bpkroth
commented
Jul 1, 2024
motus
approved these changes
Jul 2, 2024
@motus I'm thinking we cut a new release after this and the OneShotOptimizer fixups are in. |
bpkroth
added a commit
that referenced
this pull request
Jul 3, 2024
Builds off of #762, #763, and #764. Prepares rules and configs to enable isort and black formatters and checks but doesn't enable them yet. After these are enabled (next PR) we will reformat all files and ignore that revision in git blame configs. Then, we can convert configs stored in `setup.cfg` and `.pylintrc` to the top level `pyproject.toml` and remove the older configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #762 and #763
These are in part
black
that only acceptpyproject.toml
files as their configuration files).To do so, we move some configs from
setup.py
topyproject.toml
for each module.However, to retain the ability to rewrite URLs in published README.md files on PyPi as well as consistent version dependencies across modules without the need to manually specify version numbers (e.g., using
setuptools-scm
) we mark a few dependencies as dynamic and leave our existing logic inside thesetup.py
file.Finally, we reorganize the
version.py
file to be inside the module and fix a few previous omissions formlos_viz
.