update method call and rerun notebooks #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
commented
Sep 14, 2020
| @@ -485,7 +485,7 @@ | |||
| "# evaluate the surrogate\n", | |||
| "surrogate_predictions = optimizer.predict(pd.DataFrame({'x': line})).get_dataframe()\n", | |||
| "# plot observations\n", | |||
| "feature_values, target_values = optimizer.get_experiment_data()\n", | |||
| "feature_values, target_values = optimizer.get_all_observations()\n", | |||
There was a problem hiding this comment.
This is the main substantial change in this PR, the method was renamed.
There was a problem hiding this comment.
This type of thing should get caught when we finish #55
amueller
commented
Sep 14, 2020
| @@ -103,8 +103,8 @@ | |||
| "text/plain": [ | |||
| "smart_cache_config\n", | |||
| "implementation: [LRU, MRU]\n", | |||
| "lru_cache_config.cache_size: {1, 1 + 1, ... , 4096}\n", | |||
| "mru_cache_config.cache_size: {1, 1 + 1, ... , 4096}" | |||
| "lru_cache_config.cache_size: {1, 2, 3, ... , 4096}\n", | |||
There was a problem hiding this comment.
this is a meaningful change in output because of updates in the code. The remaining changes are incidental. yay!
|
Assuming you tested it, so LGTM! |
bpkroth
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fixup for class notebooks @bpkroth @byte-sculptor