Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: is_defaults() is a method, not property #782

Merged
merged 2 commits into from
Jul 10, 2024
Merged

bugfix: is_defaults() is a method, not property #782

merged 2 commits into from
Jul 10, 2024

Conversation

motus
Copy link
Member

@motus motus commented Jul 9, 2024

Closes #781

@motus motus added bug Something isn't working ready for review Ready for review mlos-bench labels Jul 9, 2024
@motus motus self-assigned this Jul 9, 2024
@motus motus requested a review from a team as a code owner July 9, 2024 20:19
bpkroth
bpkroth approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to have some way to sanity check this for the future, but it's probably overkill. Maybe something that looks at the values and sees if they're callable and issues a warning or something like that.

@bpkroth bpkroth merged commit 5a06286 into microsoft:main Jul 10, 2024
12 checks passed
@bpkroth bpkroth mentioned this pull request Jul 11, 2024
Merged
DelphianCalamity pushed a commit to DelphianCalamity/MLOS that referenced this pull request Jul 12, 2024
@motus @bpkroth @DelphianCalamity
bugfix: is_defaults() is a method, not property (microsoft#782)
1cacddd 
Closes microsoft#781

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
bpkroth added a commit that referenced this pull request Jul 24, 2024
@bpkroth @motus
Test that the config provided is serializable (#790)
6c563e1 
Test for #782

Makes `new_trial` a wrapper with a sanity check and renames the previous
`new_trial` abstractmethod to `_new_trial`.

---------

Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
@motus motus deleted the sergiym/sched/is_defaults branch August 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
bug Something isn't working mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storing is_defaults causing storage column length issues when too many tunables
2 participants
@motus @bpkroth