Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_update_status was called twice leading to mysql.connector.errors.IntegrityError #796

Closed
wants to merge 1 commit into from
Closed

_update_status was called twice leading to mysql.connector.errors.IntegrityError #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlos_bench/mlos_bench/storage/sql/trial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ def update_telemetry(
# and we need to keep `.update_telemetry()` idempotent; hence a loop instead of
# a bulk upsert.
# See Also: comments in <https://github.com/microsoft/MLOS/pull/466>
with self._engine.begin() as conn:
self._update_status(conn, status, timestamp)
# with self._engine.begin() as conn:
# self._update_status(conn, status, timestamp)
for metric_ts, key, val in metrics:
with self._engine.begin() as conn:
try:
Expand Down
Loading