Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy 1.11 warnings #809

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix mypy 1.11 warnings #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8224975
get rid of new mypy 1.11 warnings
motus Jul 19, 2024
dcddc94
Merge branch 'main' into sergiym/ci/mypy-1.11
motus Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlos_core/mlos_core/tests/optimizers/optimizer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def objective(x: pd.Series) -> pd.DataFrame:
def test_concrete_optimizer_type(optimizer_type: OptimizerType) -> None:
"""Test that all optimizer types are listed in the ConcreteOptimizer constraints."""
# pylint: disable=no-member
assert optimizer_type.value in ConcreteOptimizer.__constraints__ # type: ignore[attr-defined]
assert optimizer_type.value in ConcreteOptimizer.__constraints__


@pytest.mark.parametrize(
Expand Down
5 changes: 1 addition & 4 deletions mlos_core/mlos_core/tests/spaces/adapters/space_adapter_factory_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@
def test_concrete_optimizer_type(space_adapter_type: SpaceAdapterType) -> None:
"""Test that all optimizer types are listed in the ConcreteOptimizer constraints."""
# pylint: disable=no-member
assert (
space_adapter_type.value
in ConcreteSpaceAdapter.__constraints__ # type: ignore[attr-defined]
)
assert space_adapter_type.value in ConcreteSpaceAdapter.__constraints__


@pytest.mark.parametrize(
Expand Down
Loading