Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quantization -> quantization_bins #844

Merged
merged 41 commits into from
Aug 16, 2024

Conversation

motus
Copy link
Member

@motus motus commented Aug 15, 2024

Merge after (or instead of) #835

diff from #835 :: https://github.com/motus/MLOS/pull/15/files

Closes #803

motus and others added 30 commits August 5, 2024 16:38
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus motus self-assigned this Aug 15, 2024
@motus motus requested a review from a team as a code owner August 15, 2024 20:06
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebasing after #835

@bpkroth bpkroth merged commit fadfacb into microsoft:main Aug 16, 2024
12 of 13 checks passed
bpkroth added a commit that referenced this pull request Aug 16, 2024
Bump version after #844 which represents a breaking config schema
change.
@motus motus deleted the sergiym/tunable/quantization_bins_rename branch August 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement quantization for ConfigSpace >= 1.0
2 participants