Move quantization_bins into meta field of NumericalHyperaparameter #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
Aug 20, 2024
bpkroth
commented
Aug 20, 2024
bpkroth
commented
Aug 20, 2024
bpkroth
commented
Aug 20, 2024
* a bit cleaner definition of test config spaces * update test results to match the values returned from the optimizers * small fixes to the tunable to config space converter; roll back the cost update * roll back the monkey patching in the optimizer * bugfix: monkey_patch the right method in the quantization * quantization finally works properly * add one more test for ConfigSpace.sample_configuration()
motus
approved these changes
Aug 21, 2024
motus
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.