MacOS test fixups and CI pipelines #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
Nov 4, 2024
bpkroth
commented
Nov 4, 2024
bpkroth
commented
Nov 4, 2024
bpkroth
commented
Nov 4, 2024
bpkroth
changed the title
motus
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fixes some test issues for Mac OS environments and enables CI pipelines.
Description
Enable MacOS devcontainer testsNeedsdockerenabled (which isn't currently possible)Related: add basic devcontainer build test and run for Windows as well (also isn't currently possible)Publish multi arch docker images (amd64 and arm64) (can't see above)Closes #875
Type of Change
Testing
Locally tested on MacOS, Windows, and Linux.
Additional Notes (optional)
Leaves some currently disabled stub code for creating devcontainers in the future on MacOS and Windows hosts. Unfortunately this isn't currently possible with the Github Action runners.
Also did some cosmetic renaming of the CI pipelines for better descriptions.
This affects the required tests to pass in the repo settings.
Will adjust that after this is approved.