Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loading configs from JSON strings and test with new docstrings for tunables #890

Merged
merged 31 commits into from
Dec 6, 2024
Merged

Allow loading configs from JSON strings and test with new docstrings for tunables #890

merged 31 commits into from
Dec 6, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Dec 4, 2024 •
edited
Loading

Pull Request

Title

Allow loading configs from JSON strings not just files and add docs for Tunables to demonstrate and test it.

Description

Adds basic support for loading a JSON config string directly.

The main purpose is to be able to show examples in docstrings that are testable (so that they don't become stale examples).

Type of Change

  • ✨ New feature
  • 📝 Documentation update
  • 🧪 Tests

Testing

  • Adds additional unit tests.

Additional Notes (optional)

Split out from #887

@bpkroth bpkroth changed the title basic stub for allowing loading configs as json strings for docstring… Allow loading configs from JSON strings not just files Dec 4, 2024
@bpkroth bpkroth added the WIP Work in progress - do not merge yet label Dec 4, 2024
@bpkroth bpkroth marked this pull request as ready for review December 5, 2024 20:03
@bpkroth bpkroth requested a review from a team as a code owner December 5, 2024 20:03
@bpkroth bpkroth changed the title Allow loading configs from JSON strings not just files Allow loading configs from JSON strings and test with new docstrings for tunables Dec 5, 2024
@bpkroth bpkroth added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Dec 5, 2024
@bpkroth bpkroth enabled auto-merge (squash) December 5, 2024 20:19
@bpkroth bpkroth mentioned this pull request Dec 5, 2024
Open
10 tasks
@bpkroth bpkroth disabled auto-merge December 5, 2024 22:03
@bpkroth bpkroth enabled auto-merge (squash) December 5, 2024 22:51
@bpkroth bpkroth disabled auto-merge December 6, 2024 19:32
@bpkroth bpkroth enabled auto-merge (squash) December 6, 2024 21:37
@bpkroth bpkroth disabled auto-merge December 6, 2024 22:00
@bpkroth bpkroth merged commit 74665c6 into microsoft:main Dec 6, 2024
16 of 17 checks passed
bpkroth added a commit to Microsoft-CISL/sqlite-autotuning that referenced this pull request Dec 13, 2024
@bpkroth
Fixups following microsoft/MLOS#890
81b37b4
@bpkroth bpkroth mentioned this pull request Dec 13, 2024
Merged
bpkroth added a commit to Microsoft-CISL/sqlite-autotuning that referenced this pull request Dec 13, 2024
@bpkroth
Fixups following microsoft/MLOS#890 (#50)
9d1852c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to load class instances from json config string, not just a file
2 participants
@bpkroth @motus