Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage API having SMAC as a required dependency #899

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

eujing
Copy link
Contributor

@eujing eujing commented Dec 12, 2024

Pull Request

Fix storage API having SMAC as a required dependency


Description

Fixes #898 by moving import away from top-level.


Type of Change

  • 🛠️ Bug fix

Testing

Ran existing mlos_core unit tests, and manually tested in a fresh python env without optional deps installed.


@eujing eujing requested a review from a team as a code owner December 12, 2024 01:48
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As per my usual mantra, we should add tests, but I think we can merge this and tackle that as a part of #343.
Thanks!

@eujing eujing merged commit 0d43b2e into microsoft:main Dec 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMAC package now required for using storage API
3 participants