Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCToolsVersion and NETCoreSdkVersion properties to fingerprints #77

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Jul 23, 2024

Add VCToolsVersion and NETCoreSdkVersion properties to fingerprints

These are to help with the situation of build tooling like VS updating and some projects coming from cache from the old version while newer projects are rebuilt.

For VCToolsVersion, the linker is not able to handle obj files which were compiled with different versions of the compiler:

LINK(0,0): Error C1047: The object or library file 'D:\a_work\1\s\x64\Release\spdlog.lib' was created by a different version of the compiler than other objects like 'x64\Release\dllmain.obj'; rebuild all objects and libraries with the same compiler

For NETCoreSdkVersion, upgrading the SDK may upgrade the bundled runtime runtime. This can lead to an older runtime being copied, which fails as it's usually no longer installed, not to mention being undesirable to use an older patch version of the runtime):

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(5270,5): Error MSB3030: MSB3030: Could not copy the file "C:\hostedtoolcache\windows\dotnet\packs\Microsoft.NETCore.App.Host.win-x64\8.0.6\runtimes\win-x64\native\Ijwhost.dll" because it was not found.

@dfederm dfederm merged commit becf0aa into main Jul 23, 2024
6 checks passed
@dfederm dfederm deleted the dfederm/tooling-changes branch July 23, 2024 18:13
DHowett pushed a commit to microsoft/PowerToys that referenced this pull request Jul 24, 2024
Update MSBuildCache to 0.1.283-preview

Notable change is this one, which should avoid under-builds when the
build tooling updates: microsoft/MSBuildCache#77

Full release notes:
*
[0.1.283-preview](https://github.com/microsoft/MSBuildCache/releases/tag/v0.1.283-preview)
*
[0.1.273-preview](https://github.com/microsoft/MSBuildCache/releases/tag/v0.1.273-preview)
DHowett pushed a commit to microsoft/terminal that referenced this pull request Jul 26, 2024
Update MSBuildCache to 0.1.283-preview

Notable change is this one, which should avoid under-builds when the
build tooling updates: microsoft/MSBuildCache#77

Full release notes:
[0.1.283-preview](https://github.com/microsoft/MSBuildCache/releases/tag/v0.1.283-preview)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants