Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to query nodes recursively if needed #93

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Oct 14, 2024

Add ability to query nodes recursively if needed

This feature allows the plugin to on-demand query for dependencies which have not been queried. Most scenarios are expected to do a "graph build" and ensure all dependencies are built first, but some upcoming scenarios might violate that constraint.

This is an opt-in scenario since it adds some overhead and can make cache misses more expensive.

@dfederm
Copy link
Member Author

dfederm commented Oct 14, 2024

TODO! Add docs for new setting

Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super-familiar with the plugin so my approval is somewhat weak, but the changes look good.

@dfederm dfederm enabled auto-merge (squash) October 21, 2024 19:57
@dfederm
Copy link
Member Author

dfederm commented Oct 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dfederm dfederm merged commit b403564 into main Oct 21, 2024
6 checks passed
@dfederm dfederm deleted the get-unqueried-deps branch October 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants