Error if msbuild already loaded #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .NET assembly loader ensures that any assembly referenced by a method is loaded before the method is called. This requires that MSBuildLocator be called **before any method that references MSBuild**. That's a confusing requirement, and easy to forget. But it's easy to check for, and since we expect the locator to be called roughly once per process, not too expensive to check for at `RegisterInstance` time. Produces an error like ``` Unhandled Exception: System.InvalidOperationException: Microsoft.Build.Locator.MSBuildLocator.RegisterInstance was called, but MSBuild assemblies were already loaded. Ensure that RegisterInstance is called before any method that directly references types in the Microsoft.Build namespace has been called. Loaded MSBuild assemblies: Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a at Microsoft.Build.Locator.MSBuildLocator.RegisterInstance(VisualStudioInstance instance) at Microsoft.Build.Locator.MSBuildLocator.RegisterDefaults() at MultiProcBuilderApplication.Program.Main(String[] args) in s:\work\MultiProcBuilderApplication\MultiProcBuilderApplication\Program.cs:line 13 ```
AndyGerlicher
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET assembly loader ensures that any assembly referenced by a
method is loaded before the method is called. This requires that
MSBuildLocator be called before any method that references MSBuild.
That's a confusing requirement, and easy to forget. But it's easy to
check for, and since we expect the locator to be called roughly once per
process, not too expensive to check for at
RegisterInstancetime.Produces an error like