Check PublicKeyToken before resolving an assembly #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rainersigwald test this please |
* If there is a request for one of our assemblies with another key do not handle the AssemblyResolve event to let other resolvers have a chance. Closes microsoft#23
AndyGerlicher
force-pushed
the
addkeycheck
branch
from
6b23661 to
1039399
Compare
rainersigwald
approved these changes
Apr 5, 2018
| var sb = new StringBuilder(); | ||
| foreach (var b in publicKeyToken) | ||
| { | ||
| sb.Append($"{b:x2}"); |
| return false; | ||
| } | ||
|
|
||
| var sb = new StringBuilder(); |
There was a problem hiding this comment.
new StringBuilder(MSBuildPublicKeyToken.Length);to avoid allocations. Though I guess there'll be garbage strings for each byte later so it probably doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not handle the AssemblyResolve event to let other resolvers have a
chance.